Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/8.0] Bump Microsoft.Private.IntelliSense package version #92254

Merged
merged 2 commits into from
Sep 19, 2023
Merged

[release/8.0] Bump Microsoft.Private.IntelliSense package version #92254

merged 2 commits into from
Sep 19, 2023

Conversation

carlossanlop
Copy link
Member

@carlossanlop carlossanlop commented Sep 18, 2023 •
edited
Loading

@carlossanlop carlossanlop added documentation Documentation bug or enhancement, does not impact product or test code area-Infrastructure labels Sep 18, 2023
@carlossanlop carlossanlop added this to the 8.0.0 milestone Sep 18, 2023
@carlossanlop carlossanlop self-assigned this Sep 18, 2023
@ghost
Copy link

ghost commented Sep 18, 2023

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

This is the package for RC2.

Generated from https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=386331&view=logs&j=fd490c07-0b22-5182-fac9-6d67fe1e939b&t=11e7ea89-affe-5194-cdc6-0171c3394706

Author: carlossanlop
Assignees: carlossanlop
Labels:

documentation, area-Infrastructure
Milestone: 8.0.0

@carlossanlop
Copy link
Member Author

carlossanlop commented Sep 18, 2023 •
edited
Loading

@mthalman heads-up: I'll manually update source-build-reference-packages with this new version like we did in dotnet/source-build-reference-packages#774

Edit: The PR is up and ready: dotnet/source-build-reference-packages#787

@carlossanlop carlossanlop mentioned this pull request Sep 18, 2023
Merged
@carlossanlop carlossanlop added the Servicing-approved Approved for servicing release label Sep 18, 2023
@ViktorHofer
Copy link
Member

Do not merge before the source-build-reference-packages PR is merged and the update PR merged into dotnet/runtime. Otherwise the CI will break.

@build-analysis build-analysis bot mentioned this pull request Sep 19, 2023
Closed
@carlossanlop
Copy link
Member Author

Do not merge before the source-build-reference-packages PR is merged and the update PR merged into dotnet/runtime. Otherwise the CI will break.

Do we need to trigger a dependency flow to release/8.0 manually, @mthalman?

@mthalman
Copy link
Member

Do not merge before the source-build-reference-packages PR is merged and the update PR merged into dotnet/runtime. Otherwise the CI will break.

Do we need to trigger a dependency flow to release/8.0 manually, @mthalman?

First, the change needs to be ported to 8.0 branch in SBRP: dotnet/source-build-reference-packages#787 (comment). Then the dependency will flow to release/8.0 in runtime repo. Looks like the darc subscription triggers once a day for that. So it'll need to be manually triggered to get it sooner.

@carlossanlop
Copy link
Member Author

The SBRP deps flow PR needs to be merged before we merge this: #92143

@mthalman
Copy link
Member

The SBRP deps flow PR needs to be merged before we merge this: #92143

They're dependent on each other so they'll need to be combined. #92143 causes source-build prebuilts that are resolved by this PR.

@carlossanlop carlossanlop mentioned this pull request Sep 19, 2023
Merged
@carlossanlop
Copy link
Member Author

so they'll need to be combined

Is it ok if I just merge one after the other instead? I don't want to reset the CI again, as we are already behind with the RC2 snap.

@mthalman
Copy link
Member

so they'll need to be combined

Is it ok if I just merge one after the other instead? I don't want to reset the CI again, as we are already behind with the RC2 snap.

That's fine. As long as source-build continues to work in the branch, I'm happy.

@carlossanlop carlossanlop merged commit 47b85fe into dotnet:release/8.0 Sep 19, 2023
170 of 181 checks passed
@carlossanlop carlossanlop deleted the BumpIntellisenseRC2 branch September 19, 2023 19:24
@mthalman mthalman mentioned this pull request Sep 21, 2023
Closed
@radical radical mentioned this pull request Sep 26, 2023
Closed
@radical radical mentioned this pull request Oct 3, 2023
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Oct 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ericstj ericstj ericstj approved these changes

@jeffhandley jeffhandley Awaiting requested review from jeffhandley

@jkoritzinsky jkoritzinsky Awaiting requested review from jkoritzinsky

@hoyosjs hoyosjs Awaiting requested review from hoyosjs

Assignees

@carlossanlop carlossanlop

Labels
area-Infrastructure documentation Documentation bug or enhancement, does not impact product or test code Servicing-approved Approved for servicing release
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@carlossanlop @ViktorHofer @mthalman @ericstj